Member nix::AddCompletions::setType (Type type)=0: it should not be possible to change the type after it has been set.
Member nix::Args::parent: this would probably be better in the CommandClass. getRoot() could be an abstract method that peels off at most one layer before recuring.
Member nix::BuildResult::errorMsg: This should be an entire ErrorInfo object, not just a string, for richer information.
Member nix::Constant::type: we should use an enum for this.
Member nix::ExtraPathInfoValue::Value::extendedOutputsSpec: merge with DerivedPath's 'outputs' field?
Struct nix::GcStore: actually this is not so good because stores are views. Some views have only a no-op temp roots even though others to the same store allow triggering GC. For instance one can't add a root over ssh, but that doesn't prevent someone from gc-ing that store accesed via SSH locally).
Member nix::Generation::path: Use StorePath instead of Path?
Member nix::HttpBinaryCacheStore::isTrustedClient () override: try to expose our HTTP authentication status.
Member nix::Installable::getStorePath (): should we move this to InstallableDerivedPath? It is only supposed to work there anyways. Can always downcast.
Member nix::LocalDerivationGoal::makeFallbackPath (OutputNameView outputName): Add option to randomize, so we can audit whether our rewrites caught everything
Struct nix::NARParseVisitor: Fix this API, it sucks. A visitor for NAR parsing that performs filesystem (or virtual-filesystem) actions to restore a NAR.
Member nix::Nothing: currently unused, but could be revived if we can evaluate derivations in-memory.
Member nix::operator<< (Sink &sink, WorkerProto::Op op): Switch to using WorkerProto::Serialise instead probably. But this was not done at this time so there would be less churn.
Member nix::operator<< (std::ostream &s, WorkerProto::Op op): Perhaps render known opcodes more nicely.
Member nix::operator<< (std::ostream &s, ServeProto::Command op): Perhaps render known opcodes more nicely.
Member nix::operator<< (Sink &sink, ServeProto::Command op): Switch to using ServeProto::Serialize instead probably. But this was not done at this time so there would be less churn.
Class nix::RemoteStore: RemoteStore is a misnomer - should be something like DaemonStore.
Member nix::SearchPath::Path::s: Maybe change this to std::variant<SourcePath, URL>.
Member nix::SearchPath::Prefix::s: Should we normalize this when constructing a SearchPath::Prefix?
Member nix::ServeProto::Version: Convert to struct with separate major vs minor fields.
Member nix::Store::addToStoreFromDump (AsyncInputStream &dump, std::string_view name, FileIngestionMethod method=FileIngestionMethod::Recursive, HashType hashAlgo=HashType::SHA256, RepairFlag repair=NoRepair, const StorePathSet &references=StorePathSet()): remove?
Member nix::Store::parseStorePathSet (const PathSet &paths) const: remove
Member nix::Store::unsupported (const std::string &op): Using this should be a last resort. It is better to make the method "virtual pure" and/or move it to a subclass.
Member nix::ThreadPool::work_t ): use std::packaged_task?
Member nix::UnkeyedValidPathInfo::narHash: document this
Member nix::WorkerProto::Version: Convert to struct with separate major vs minor fields.